Skip to content

UnlinkRepositoryFromObjectPool: stop removing objects/info/alternates

Jacob Vosmaer requested to merge objectpool-explicit-not-found into master

Related to #1568 (closed)

Prior to this MR, UnlinkRepositoryFromObjectPool would try to remove the objects/info/alternates file of the repository being unlinked from the pool. In #1568 (closed) we discovered that this is sensitive to race conditions around the time a repository is deleted.

Considering that we only do this to repositories that are being deleted, I figured that the easiest way to make this more robust was to stop trying to delete a file that will be deleted anyway.

The only thing left in UnlinkRepositoryFromObjectPool now is to remove the remote that points to the departing repository. This can be done even if the departing repository no longer exists.

Edited by GitLab Release Tools Bot

Merge request reports