Accept a wildcard for daily_maintenance storages list
In #5997 (comment 1876650562), we ran into a situation where it's preferable for us to have Gitaly accept a wildcard (e.g. a *
) as value for daily_maintenance.storages
instead of specifying actual storage names. The wildcard would mean that all storages configured under [[storage]]
would be the target of the maintenance.
For now we have made a workaround in the cookbook that provisions Gitaly config (gitlab-cookbooks/cookbook-omnibus-gitlab!125 (merged)) but it's not ideal as it doesn't make it obvious where the value came from.
Action items
-
Implement the feature in Gitaly -
Revert the workaround in gitlab-cookbooks/cookbook-omnibus-gitlab!125 (merged) and assign a wildcard in the relevant Chef roles.