Skip to content
GitLab
Next
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    Projects Groups Snippets
  • Sign up now
  • Login
  • Sign in / Register
  • gitaly gitaly
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 658
    • Issues 658
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 49
    • Merge requests 49
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • gitalygitaly
  • Issues
  • #4549
Closed
Open
Issue created Oct 19, 2022 by Quang-Minh Nguyen@qmnguyen0711Maintainer

Add Repository actor support to feature API

In #4459 (closed), we attempted to add Feature Flag factors support to Gitaly. After careful consideration, we decided to introduce Repository actor to the actor support list. This new actor is dedicated to Gitaly at the moment. It is suitable for the data model of Gitaly. Flipper, the engine behinds GitLab feature flag, is powerful in terms of actor support. The new actor class needs to add flipper_id method. During feature flag evaluation, passing Repository in also works out of the box.

However, in practice, GitLab advocate chatops workflow so that folks can interact with feature flags directly on Slack. In addition, we also support admin APIs for the instance administrators to do the same thing with their instances. Chatops also uses the same APIs.

As a result, we'll need to add Repositroy actor to Admin feature flag APIs. Although the unique ID used by Flipper is gl_repository, it makes more sense from the user perspective to use Repository full path instead. We'll add to touch Feature::Target.

Edited Oct 19, 2022 by Quang-Minh Nguyen
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking