Introduce new WhitespaceChanges enum and deprecate ignore_whitespace_change
Following from this comment: &9028 (comment 1138747850) from @pks-t
ultimately this is a backwards-incompatible change in Gitaly that might also impact other users of it. How about we amend the CommitDiff
RPC to expose a new enum WhitespaceChanges
or similar that deprecates the ignore_whitespace_change
field? It could either be Unspecified
(we look at ignore_whitespace_change
), DontIgnore
, Ignore
or IgnoreAll
so that you can then control yourself how exactly to render the diff?
Availability & Testing
As the change in this issue is adding a new field, and potentially marking another as deprecated there shouldn't be any major issue here. Any change in behaviour in rails shouldn't happen until gitlab#378213 (closed).
- We should ensure that
omnibus-gitlab-mirror
trigged by thetrigger-qa
job passes to confirm no unexpected downstream impact
Edited by John McDonnell