Expand the GitLab QA test suite to catch Gitaly errors
As a corrective action of gitlab-com/gl-infra/production#6991 (closed).
From @toon on gitlab-com/gl-infra/production#6991 (comment 943443164)
QA should have caught this, I think. Although we probably don't test too many erroneous situations, only happy paths.
For this particular failure we could add a test, but by no means it would guarantee anything for the future, as there are many ways things can go wrong.
Nonetheless, it's kind'of a recurring theme: Gitaly changes something in their interface, and the overall application fails in unexpected ways. We should try find a solution that would not only help us detecting this particular error, but a wider range of RPCs as well. I'm not sure yet how we can accomplish that????
Proposal
Expand GitLab QA tests to catch RPCs errors introduced by Gitaly updates. QA tests could be from unit tests to end-to-end tests ensuring the Gitaly update versions are compliant with the GitLab application. Then on "Update Gitaly" MRs (e.g gitlab!87396 (merged)) we could force the execution of package-and-qa
as long as any other required spec.