Perform full integration test with SSH server for pushing remotes to external repos
In gitlab#216619 (closed), we experienced a regression where pushes to GitHub repos started failing. This was found due to a regression behind a new feature flag. This regression could have been prevented if we actually performed a full integration test with an SSH server and exercised verification of the remote host's public key.
Proposal
- Update tests for
UpdateRemoteMirror
RPC to stand up a full SSH server when pushing to an external (non-Gitaly/non-GitLab) remote. - Add a new test to assert when the remote fails pubkey verification based on the provided
known_hosts
request value.
Edited by Paul Okstad (ex-GitLab)