Pool repositories should get housekeeping.Perform called on them
For regular repositories, gitlab-rails will periodically call the GarbageCollect RPC, which will call housekeeping.Perform in Gitaly. That is a function that cleans up stale tempfiles left by Git.
For good reasons, gitlab-rails does not call GarbageCollect on pool repositories (used for Git object deduplication). The equivalent of garbage collection there is the FetchIntoObjectPool
RPC.
We have had reports of Git tempfiles not being cleaned up from pool repositories. To recover from that, I think we should modify FetchIntoObjectPool
to include a call to housekeeping.Perform.