Skip to content
Snippets Groups Projects

Move gitlab-shell log configuration into gitaly/config.toml

    • Closed Issue created by Jacob Vosmaer @jacobvosmaer-gitlab

    We have absorbed the gitlab-shell git hooks into gitaly but they still rely on the gitlab-shell config file. This reliance needs to go away.

    As a first step I propose moving the configuration for gitlab-shell logging.

    Currently there are:

    • log file
    • log level (e.g. INFO)
    • log format (text or json)
    • metrics log file

    I think this can all disappear, if we add 1 new field to gitaly's config: "log directory".

    • the standard gitlab-shell log file then always goes in the general gitaly log directory
    • the gitlab-shell log level would follow the existing gitaly log level config setting
    • the log format should follow the gitaly log format
    • the metrics log file would go in the gitaly log directory

    We can pass down the log directory using an environment variable. If this variable is not set we should fall back to the old gitlab-shell defaults; this will allow us to integrate this change smoothly.

    After this is implemented in gitaly there will be follow-up tasks for the various gitaly config generators (GDK, gitlab-ce rake task, omnibus, CNG).

    To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information

    Child items ...

    • Activity

    Please register or sign in to reply