Upgrade Go protobuf compiler to 1.2
The release notes: https://github.com/golang/protobuf/releases
V1.2
#605 jsonpb.Unmarshal correctly handles escaped strings for some of the well-known types #627 jsonpb.Unmarshal correctly returns an error when trying to marshal a scalar enum into repeated enums. #630 jsonpb.Unmarshal correctly handles string versions of numeric primitives #644 jsonpb.Unmarshal correctly handles enum values in maps #624 fixes a performance regression where nested maps led to quadratic behavior #628 reverts strict UTF-8 validation for proto2 string fields #660 makes UTF-8 validation errors for proto3 string fields non-fatal
V1.1
The serialization logic (for both Marshal and Unmarshal) has been optimized. Testing inside Google demonstrate that the new implementation is about 1.3x to 2.1x faster. protocolbuffers/protobuf#272 Unknown fields in proto3 are now preserved. #472 JSON marshal and unmarshal now check for proto2 required field. #483 GetExtension returns the raw bytes if the ExtensionDesc does not have type information. #499 Invalid UTF-8 in string types are rejected during marshal and unmarshal. #511 Fields of bad wire types are treated as unknown fields instead of an error. #544 The protoc-gen-go generator supports the paths=source_relative option. #561 Unknown fields in map entries are now ignored instead of causing an unmarshal error. #583 The "import public" feature is now implemented using Go type aliases.
Closes: gitaly#1497 (closed)
Merge request reports
Activity
I see a lot of stuff we don't care about in the changelog -- stuff that matters at runtime (in Gitaly) but not when generating the gitaly-proto *.pb.go files. On the other hand there are changes in the generated code, so this does do something.
@zj have you checked downstream compatibility? E.g. run a gitaly CI build, or gitlab-workhorse, with this proto branch vendored in?
It's not a total deal breaker if this change forces us to upgrade the protobuf library in downstream consumers but it would be good to know that before we merge here.
Edited by Jacob Vosmaerassigned to @zj
mentioned in commit gitaly@84c1a152
mentioned in merge request gitaly!1084 (merged)
mentioned in commit gitlab-workhorse@d48869f3
mentioned in merge request gitlab-workhorse!368 (merged)
Created two downstream MRs:
The Gitaly one has some error about missing values in the structs which I'll investigate today.
mentioned in commit gitaly@cbb2d9c4
@jacobvosmaer-gitlab I've updated the Gitaly MR to a state I suspect the pipeline is going to be green now. The errors I encountered were very minor, and had to do with the newly introduced struct fields.
assigned to @jacobvosmaer-gitlab
mentioned in commit gitaly@735746e2
added 3 commits
-
59f2cd65...8b12021e - 2 commits from branch
master
- eb10c739 - Upgrade Go protobuf compiler to 1.2
-
59f2cd65...8b12021e - 2 commits from branch
mentioned in commit 7d082abf
mentioned in commit gitaly@d23b1997
mentioned in commit gitaly@403f3c6c
mentioned in commit gitlab-workhorse@41852415
mentioned in issue gitaly#1497 (closed)
added devopscreate groupgitaly labels