Skip to content

reftable: honor core.fsync

Patrick Steinhardt requested to merge pks-reftable-fsync-on-compaction into master

reftable/stack: fsync "tables.list" during compaction

In 1df18a1c (reftable: honor core.fsync, 2024-01-23), we have added code to fsync both newly written reftables as well as "tables.list" to disk. But there are two code paths where "tables.list" is being written:

  • When appending a new table due to a normal ref update.

  • When compacting a range of tables during compaction.

We have only addressed the former code path, but do not yet sync the new "tables.list" file in the latter. Fix this ommission.

Note that we are not yet adding any tests. These tests will be added once the "reftable" backend has been upstreamed.

Signed-off-by: Patrick Steinhardt ps@pks.im

Closes #251 (closed).

Merge request reports