Skip to content

Reorder ep-infra rules and assign reviewers

David Dieulivol requested to merge ddieulivol-ungroup_ep_infra_qa_resources into main

Context

As stated in https://docs.renovatebot.com/configuration-options/#packagerules,

Important to know: Renovate will evaluate all packageRules and not stop once it gets a first match. You should order your packageRules in ascending order of importance so that more important rules come later and can override settings from earlier rules if needed.

The main assumption made in this MR is that the first packageRules will be the default, and every single packageRule afterwards can override single key/value.

What's in this MR

Does it work?

The dry-run in https://gitlab.com/gitlab-org/frontend/renovate-gitlab-bot/-/jobs/3937469417 looks good to me. I annotated it below:

 INFO: DRY-RUN: Would commit files to branch renovate-terraform/grafana-8.x (repository=gitlab-renovate-forks/engineering-productivity-infrastructure, branch=renovate-terraform/grafana-8.x)
 INFO: DRY-RUN: Would commit files to branch renovate-terraform/influxdb-5.x (repository=gitlab-renovate-forks/engineering-productivity-infrastructure, branch=renovate-terraform/influxdb-5.x)
 INFO: DRY-RUN: Would commit files to branch renovate-terraform/ingress-nginx-4.x (repository=gitlab-renovate-forks/engineering-productivity-infrastructure, branch=renovate-terraform/ingress-nginx-4.x)
 INFO: DRY-RUN: Would commit files to branch renovate-terraform/gitlab-15.x (repository=gitlab-renovate-forks/engineering-productivity-infrastructure, branch=renovate-terraform/gitlab-15.x)
 INFO: DRY-RUN: Would commit files to branch renovate-terraform/kubernetes-2.x (repository=gitlab-renovate-forks/engineering-productivity-infrastructure, branch=renovate-terraform/kubernetes-2.x)

These above look like renovate would:

  1. Create individual MRs for the tools 🎉
  2. Only work with major/minor upgrades (no patches)
 INFO: DRY-RUN: Would ensure closed PR comment in PR #258 (repository=gitlab-renovate-forks/engineering-productivity-infrastructure, branch=renovate-terraform/cert-manager-1.x)

The MR mentioned is already closed: https://gitlab.com/gitlab-org/quality/engineering-productivity-infrastructure/-/merge_requests/258

 INFO: DRY-RUN: Would autoclose PR (repository=gitlab-renovate-forks/engineering-productivity-infrastructure)
       "prNo": "324",
       "prTitle": "Update Default QA Resources update"

This would close https://gitlab.com/gitlab-org/quality/engineering-productivity-infrastructure/-/merge_requests/324 🎉

Edited by David Dieulivol

Merge request reports