Skip to content

Detect more submit buttons

Mark Florian requested to merge fix-submit-pajamas-button-findings into main
  • Detect more submit buttons

The previous pattern matched only an explicit f form object, but it can be called other things.

This also adds test coverage for these rules. See also !44 (merged).

Screenshots

Before After
Screenshot_2023-10-18_at_12-06-13_Pajamas_Adoption_Scanner_Dashboard Screenshot_2023-10-18_at_12-06-18_Pajamas_Adoption_Scanner_Dashboard
Screenshot_2023-10-18_at_12-05-35_Pajamas_Adoption_Scanner_Dashboard Screenshot_2023-10-18_at_12-05-39_Pajamas_Adoption_Scanner_Dashboard

Review/run this locally

  1. Copy the pages in mr job URL (must have succeeded)
  2. Run bin/review-mr.sh <job url>
Edited by Mark Florian

Merge request reports