Ignore button findings that are probably dropdowns (!222) · Merge requests · GitLab.org / Frontend / pajamas-adoption-scanner

Ignore button findings in dropdown files

For gitlab-org/gitlab@79abc488, this removes seven findings:

This is a genuine finding that should instead be migrated to a compliant dropdown (there's no point migrating the button itself):

These three are false positives, as they are deprecated filtered search items (e.g, see gitlab-org/gitlab@9949f57c for similar ones):

These are buttons in a dropdown helper Ruby module, which probably shouldn't be used at all, and simply deleted:

Ignore dropdown button findings

In total, this removes 21 button findings.

15 of these findings included dropdown in the same line as gl-button, which should be covered by dropdown rules.

These could be seen by running a scan before this commit and using this query:

extra.metadata[pajamasCompliant eq false and componentLabel eq
"component:button"] and not path co "dropdown" and extra.lines co
"dropdown"

A few examples are:

This also removes 6 more findings which weren't real button findings:

Addresses #86

Screenshots

Before	After

Edited Oct 17, 2023 by Mark Florian