Skip to content

Improve tree tooltip

Mark Florian requested to merge improve-tree-tooltip into main

Show rule message on treemap tooltip

This makes it easier to understand what each node is, and how to view the findings.


Colour treemap nodes according to compliance

This ensures that nodes representing compliant findings are blue, and and non-compliant ones are orange, using the colours from our default data visualisation theme.

The previous behaviour could be confusing under certain circumstances. Because the theme applies colours in series order (unless configured otherwise), and the treemap draws the largest levels/nodes first, those would always be blue, and the next orange, and so on as the theme specifies.

So if you grouped by compliance and looked at, say, buttons, there are more non-compliant findings there, so they would have rendered blue, while the fewer compliant findings would have been orange. This conflicted with history chart's colouring, where compliant findings are always blue and non-compliant always orange due to the explicit and fixed series ordering.


Before After
Screenshot_from_2023-03-10_13-39-24 Screenshot_from_2023-03-10_13-39-05

Review/run this locally

  1. Copy the pages in mr job URL (must have succeeded)
  2. Run bin/review-mr.sh <job url>
Edited by Mark Florian

Merge request reports