Skip to content

Remove instance Prepare context timeout

Arran Walker requested to merge ajwalker/prepare-remove-timeout into main

There's no good default to set for a prepare timeout, as different providers have different mechanisms for preparing connection information.

This fixes an issue, for example, with AWS and Windows, it can take longer than a minute to get the password that has been set.

This removes the context timeout entirely, leaving it up to the plugin to return in an appropriate amount of time.

An alternative could have been allowing a user provided timeout, but again, plugins should know best on the limit to set, and when they don't, the plugin itself can provide such a timeout parameter.

gitlab-org/gitlab-runner#29598 (closed)

Edited by Darren Eastman

Merge request reports