Database Group Triage for week ending 2023-09-08

About

This issue is used by groupdatabase to triage issues and make sure they get properly assigned and prioritized. Each week, a bot will look up the old issue, pick the next assignee in the list, and submit a new issue with a list of any issues that may need attention from the team.

Last week's issue

Process

• Review any issues identified for triage
• Review any issues with undefined types
• Post any questions or pressing issues to the database group meeting doc
• Post a comment on the database group status issue

  For triage this week there were 2 issues in need of triage, 9 issues without throughput labels, and 13 other database issues reviewed. <link to this issue>

Issues needing triage (Labeled databasetriage)

For each issue below:

1. If the issue needs further investigation, spend up to 1 hour of investigating or fixing the issue.
2. If the issue is a typebug, assign it one of severity1, severity2, severity3, or severity4
3. Document any findings you make in a comment on the issue, and if the issue still needs additional work or refinement, consider looping in @alexives and @rogerwoo to help with scheduling and priority.
4. If the issue is incomplete, labeled ~"workflow::scheduled", and will take more than an hour to fix, remove databasetriage

• Analyze partitioned parent tables on a schedule
• Improve the user experience of manually finalizing batched background migrations

Bugs needing Severity

For each issue below:

1. For each typebug, spend up to 1 hour investigating or fixing the issue.
2. Assign it one of severity1, severity2, severity3, or severity4
3. Document any findings you make in a comment on the issue, and if the issue still needs additional work or refinement, consider looping in @alexives and @rogerwoo to help with scheduling and priority.

• Exceptions are being silently rescued from db:migrations job
• Patch ci_max_total_yaml_size_bytes migration to handle integer overflow
• Admin Job's running page fails with 500 error
• Reduce time for service discovery to update after database replica dns change
• Fix change_column_type_concurrently and undo_cleanup_concurrent_column_type_change

Issues with Undefined Type

For each issue below:

1. Assess if the issue is appropriately assigned to groupdatabase, if not add the correct group label.
2. Add the proper work type label, or if the issue is a request for support, redirect the user to our support resources with the following message:

   Hey @author. Based on the information given, this request for support is out of the scope of the issue tracker (which is for new bug reports and feature proposals). Unfortunately, I won't be able to help get it resolved. However, for support requests we have several resources that you can use to find help and support from the Community, including:
   * [Technical Support for Paid Tiers](https://about.gitlab.com/support/)
   * [Community Forum](https://forum.gitlab.com/)
   * [Reference Documents and Videos](https://about.gitlab.com/get-help/#references)
   
   Please refer to our [Support page](https://about.gitlab.com/support/) for more information.
   
   If you believe this was closed in error, please feel free to re-open the issue.
   
   /label ~"support request"
   /close

3. If the issue needs further investigation, add databasetriage and spend up to 1 hour of investigating the issue.
4. Document any findings you make in a comment on the issue, and if the issue still needs additional work or refinement, consider looping in @alexives and @rogerwoo to help with scheduling and priority.

• [Feature flag] Rollout of database_analyze_on_partitioned_tables
• Validate ignored_columns when removing a DB column
• test
• Manual DB Migration - PG::UnableToSend: no connection to the server
• why is 15.11.13 a required upgrade stop?
• Analyze partitioned parent tables on a schedule
• After gitlab9.1.2 is upgraded to 9.2.10, 500 error is reported when entering the administrator account
• Avoid rescheduling migrations again by using a trigger if nulls are added
• error dumping the contents of table "merge_request_diff_files" failed PQgetResult failed

Recent issues labeled database

For each issue below:

1. If the issue has no group label, consider if it should be addressed by groupdatabase and if so label it.
2. If the issue has a group, and you think they may need assistance from us:
   • If the issue needs further investigation, add databasetriage and spend up to 1 hour of investigating the issue.
   • Document any findings you make in a comment on the issue, and if the issue still needs additional work or refinement, consider looping in @alexives and/or @rogerwoo

• groupthreat insights Create database columns to store CVSS vector
• grouptenant scale PG14 Timeout: Query for GET /api/:version/projects times out after pg14 upgrade
• groupproject management PG 14 Query Timeout: Issue states using memoize
• grouptenant scale PG14 Timeout: Query for GET /api/:version/users times out after PG14 upgrade
• grouptenant scale PG14 Timeout: Query for /api/:version/projects/:id/events times out after PG14 upgrade
• grouptenant scale PG14 Timeout: Query for /api/:version/projects times out after PG14 upgrade
• grouptenant scale PG14 Timeout: Query for GET /api/:version/users times out after PG14 upgrade
• grouptenant scale PG14 Timeout: Query for /api/:version/groups times out after pg14 upgrade
• groupcode review Add range partitioning helper
• groupthreat insights Consider if Vulnerability::StateTransitions should be considered an Audit Trail
• ~"group::authentication and authorization" Failure in LDAP E2E test jobs in master | ActiveRecord::StatementInvalid: PG::UndefinedTable: ERROR: relation "feature_gates" does not exist
• groupthreat insights index_vulnerabilities_on_finding_id synchronous database index addition
• groupsource code Inconsistent schema of push_rules table

Recent mentions of @gitlab-org/database-team

For each mention below:

1. If the item already has an adequate response, move on to the next
2. If the mention is from someone looking to provide feedback on database review, and nobody has responded yet, set up a coffee chat with them and make a note in the thread that you did. Record feedback in the feedback issue.
3. If you know how to respond to the comment, post a response
4. If you don't know how, redirect with a specific mention to someone who may be able to respond

• @l.rosa mentioned the team on Validate ignored_columns when removing a DB column
• @dfrazao-gitlab mentioned the team on Required Stops: Research and set a time threshold for background migrations

Customer Issue Hand-offs

For each issue below:

1. If the item already has a back and forth, check in with the @stomlinson to see if what needs to be handed off
2. Consider if it's right for our team and if not, ask the support rep to follow up with the correct team.
3. If the item is right for our team, spend some time accessing it and trying to assist.
4. If you need help, and the request seems pressing, ask in the team channel if there's someone who can help dig into it.

• Questions regarding fine tuning PgBouncer connection pooling and PSQL max connections~"Help group::Database"

@alexives if @dfrazao-gitlab isn't available this week, please reassign to @jon_jenkins cc @rogerwoo