Database Group Triage for week ending 2023-08-25

About

This issue is used by groupdatabase to triage issues and make sure they get properly assigned and prioritized. Each week, a bot will look up the old issue, pick the next assignee in the list, and submit a new issue with a list of any issues that may need attention from the team.

Last week's issue

Process

• Review any issues identified for triage
• Review any issues with undefined types
• Post any questions or pressing issues to the database group meeting doc
• Post a comment on the database group status issue

  For triage this week there were 3 issues in need of triage, 2 issues without throughput labels, and 6 other database issues reviewed. <link to this issue>

Issues needing triage (Labeled databasetriage)

For each issue below:

1. If the issue needs further investigation, spend up to 1 hour of investigating or fixing the issue.
2. If the issue is a typebug, assign it one of severity1, severity2, severity3, or severity4
3. Document any findings you make in a comment on the issue, and if the issue still needs additional work or refinement, consider looping in @alexives and @rogerwoo to help with scheduling and priority.
4. If the issue is incomplete, labeled ~"workflow::scheduled", and will take more than an hour to fix, remove databasetriage

• Error in notifier job: notifier/migration.rb:201:in init_queries': undefined method map' for nil:NilClass (NoMethodError)
• Improve the user experience of manually finalizing batched background migrations
• Batched background migrations marked as finished but finished_at is not populated

Bugs needing Severity

For each issue below:

1. For each typebug, spend up to 1 hour investigating or fixing the issue.
2. Assign it one of severity1, severity2, severity3, or severity4
3. Document any findings you make in a comment on the issue, and if the issue still needs additional work or refinement, consider looping in @alexives and @rogerwoo to help with scheduling and priority.

• Error in notifier job: notifier/migration.rb:201:in init_queries': undefined method map' for nil:NilClass (NoMethodError)
• Fix change_column_type_concurrently and undo_cleanup_concurrent_column_type_change

Issues with Undefined Type

For each issue below:

1. Assess if the issue is appropriately assigned to groupdatabase, if not add the correct group label.
2. Add the proper work type label, or if the issue is a request for support, redirect the user to our support resources with the following message:

   Hey @author. Based on the information given, this request for support is out of the scope of the issue tracker (which is for new bug reports and feature proposals). Unfortunately, I won't be able to help get it resolved. However, for support requests we have several resources that you can use to find help and support from the Community, including:
   * [Technical Support for Paid Tiers](https://about.gitlab.com/support/)
   * [Community Forum](https://forum.gitlab.com/)
   * [Reference Documents and Videos](https://about.gitlab.com/get-help/#references)
   
   Please refer to our [Support page](https://about.gitlab.com/support/) for more information.
   
   If you believe this was closed in error, please feel free to re-open the issue.
   
   /label ~"support request"
   /close

3. If the issue needs further investigation, add databasetriage and spend up to 1 hour of investigating the issue.
4. Document any findings you make in a comment on the issue, and if the issue still needs additional work or refinement, consider looping in @alexives and @rogerwoo to help with scheduling and priority.

• Improve the user experience of manually finalizing batched background migrations
• Avoid rescheduling migrations again by using a trigger if nulls are added

Recent issues labeled database

For each issue below:

1. If the issue has no group label, consider if it should be addressed by groupdatabase and if so label it.
2. If the issue has a group, and you think they may need assistance from us:
   • If the issue needs further investigation, add databasetriage and spend up to 1 hour of investigating the issue.
   • Document any findings you make in a comment on the issue, and if the issue still needs additional work or refinement, consider looping in @alexives and/or @rogerwoo

• groupthreat insights Drop vulnerability_occurrence_pipelines
• groupthreat insights Backfill first_pipeline_id and latest_pipeline_id
• groupthreat insights Add columns first_pipeline_id and latest_pipeline_id to vulnerability_occurrences
• groupcomposition analysis [Feature flag] Cleanup compressed_package_metadata_synchronization
• groupdistribution Error connecting to the database: PQsocket() can't get socket descriptor
• groupcontainer registry Use postgres_foreign_keys for constraint validations

Customer Issue Hand-offs

@praba.m7n please add a comment providing any hand-off details to @stomlinson about the following issues. If an issue won't be handed off, make a comment on this issue.

• Patroni failover breaks cluster and requires a manual restart on PgBouncer hosts~"Help group::Database"
• Questions regarding fine tuning PgBouncer connection pooling and PSQL max connections~"Help group::Database"

@alexives if @stomlinson isn't available this week, please reassign to @dfrazao-gitlab cc @rogerwoo