Skip to content

Add suggestion for migrations over 20 minutes to contact Release Managers

Alex Ives requested to merge 6/suggest_if_sre_needs_notification into master
  • Add suggestion for migrations over 20 minutes to contact SRE
  • Also switched to using the active support integer time patch so that we can call "4.minutes" for added clarity

Relates to #6 (closed)

@abrandl - does 20 minutes seem like the right amount for notifying SRE? Should it be more? Less? Seems like we don't typically notice a migration is taking a long time for longer than that, so it could probably be higher.

Warnings Example:

4 Warnings
⚠ 20200325104758 - AddTestMigrationThatExceedsTimingForRegularButNotPost may need a
post-deploy migration to comply with timing guidelines. It took 5.08min, but should not exceed 3.0min
⚠ 20201015154529 - AddMigrationThatRequiresBackground took 25.02min. Please add a comment that
mentions Release Managers (@gitlab-org/release/managers) so they are informed.
⚠ 20201015154529 - AddMigrationThatRequiresBackground may need a background migration to
comply with timing guidelines. It took 25.02min, but should not exceed 10.0min
⚠ 20210604233157 - MigrationThrowsException did not complete successfully, check the job log
for details
Edited by Alex Ives

Merge request reports