Remove legacy license retrieval logic
Problem
As part of #658 (closed), we introduced new logic to the customers-app and license-app to retrieve licenses using the zuora_subscription_name
. The logic in the customers-app is behind a feature flag license_lookup_by_subscription_name
. Once we've verified that the new logic is working well, there is no need to keep the old logic.
Proposal
-
Verify the new logic is working as intended. -
Create an MR in the customers-app to remove the old retrieval logic and remove the references to the license_lookup_by_subscription_name
feature flag. Reference !818 for more information. This is the MR where the new logic was introduced. -
Create an MR in the license-app to review the old retrieval logic. Reference https://gitlab.com/gitlab-org/license-gitlab-com/merge_requests/131 for more information. This is the MR where the new logic was introduced. -
Remove the feature flag license_lookup_by_subscription_name
from https://gitlab.com/gitlab-org/customers-gitlab-com/-/feature_flags.
Result
Cleaner code by removing unnecessary code.
Next steps (if any)
How will we measure success?
No errors when downloading licenses from the customers app.
Edited by Tyler Amos