Code Review 18.2 Planning : June

Release planning for the Code Review Group

Overview - 18.2 Release Board

Backend

Planning distribution

Priorities

  1. security &17042, in order of due date:
    1. https://gitlab.com/gitlab-org/gitlab/-/issues/547628
    2. https://gitlab.com/gitlab-org/gitlab/-/issues/522926
    3. https://gitlab.com/gitlab-org/gitlab/-/issues/525338 - cannot reproduce yet
    4. https://gitlab.com/groups/gitlab-org/-/epics/17656
    5. https://gitlab.com/gitlab-org/gitlab/-/issues/542103
  2. infradev
    1. https://gitlab.com/groups/gitlab-org/-/epics/16906 - implement
    2. &13435 - step 2
  3. corrective action &13512
    1. https://gitlab.com/groups/gitlab-org/-/epics/17117 - suggest closing as won't do
    2. TODO: Review other actions to stack rank
  4. AI
  5. Bugs
    1. https://gitlab.com/gitlab-org/gitlab/-/issues/548046
  6. Cells 1.0 - &12795
    1. @kerrizor continues on merge_request_diff_files.
    2. @kinsingh handover for merge_request_diff_commit_users: &16677 (comment 2553896630)
    3. @marc_shaw continues on notes: gitlab#444222
  7. Spike for poly-repo? &17289 - API only, only association of MR to Changeset. To understand the effort. Check existing artifacts (doc), connect with engineers who've looked into this at high level. At least set up a call to get familiar with it. Outcome: we have some higher confidence of how long this would take, validate the initial confidence estimate.
  8. Intelligent MR reviewer selection
  9. Stacked Diffs for the CLI - &12025 - continue
  10. Instrumentation for the CLI - &17157 - analyze events data.
  11. Rebase & merge in 1 click - &16803 - in rollout
  12. Rapid Diffs - &13764 (closed) - no work planned.

Frontend

Planning distribution

Priorities

Priorities

  1. Rollout Action Focused MR Homepage
    1. ensure caching bug is fixed.
    2. buffer for last min polish
  2. Cleanup Reviewer sidebar
  3. Composer AI into Work Items / Issues
    1. FF can be turned on for users.
    2. Prepare handover/figure out plan.
  4. Rapid Diffs
    1. Spike for Discussions
    2. MR Creation Form default to ON
    3. Compare revisions rollout
    4. Optimizing performance (maintenance)
    5. Mobile bugs

Tech Roadmap:

  • Bugs
  • Feature flags
  • Vite

Issues scheduled for 18.2

Unassigned issues backend / frontend (should be empty by the end of planning)
display: table
fields: epic, title, assignee, weight, labels("type::*", "backend", "frontend")
query:
  group = "gitlab-org" and label = "group::code review"
  and label in ("backend", "cli", "frontend") and label != "type::ignore"
  and milestone = "18.2" and state = opened
  and assignee = none
Scheduled issues (sort by epic) backend
display: table
fields: epic, title, assignee, weight, labels("type::*", "Deliverable", "Stretch")
query:
  group = "gitlab-org" and label = "group::code review"
  and label in ("backend", "cli") and label != "type::ignore"
  and milestone = "18.2" and state = opened
Scheduled issues (sort by epic) frontend
display: table
fields: epic, title, assignee, weight, labels("type::*")
query:
  group = "gitlab-org" and label = "group::code review"
  and label in ("frontend") and label != "type::ignore"
  and milestone = "18.2" and state = opened

Slippage from 18.1

Open backend issues from 18.1
display: table
fields: health, assignee, weight, labels("backend-weight::*", "workflow::*"), labels( "Deliverable", "Stretch"), title
query:
  group = "gitlab-org" and state = opened and milestone = "18.1"
  and assignee in ("garyh", "kinsingh", "marc_shaw", "patrickbajao", "dskim_gitlab") 
Open frontend issues from 18.1
display: table
fields: health, assignee, weight, labels("frontend-weight::*", "workflow::*"), labels( "Deliverable", "Stretch"), title
query:
  group = "gitlab-org" and state = opened and milestone = "18.1"
  and assignee in ("iamphill", "slashmanov", "thomasrandolph") 

Candidate issues to consider

High priority

Saturation issues: GitLab.com Resource Saturation
display: table
fields: labels("severity*"), labels("priority*"), title, epic, assignee, milestone
query:
  type in (Issue, Epic)
  and group = "gitlab-org" and label = "group::code review"
  and label = "GitLab.com Resource Saturation"
  and state = opened

Next 1-3 releases

Open backend issues from Next 1-3 releases
display: table
fields: epic, title, assignee, weight, labels("backend-weight::*", "workflow::*")
query:
  group = "gitlab-org" and label = "group::code review"
  and label in ("backend") and label != "type::ignore"
  and milestone = "Next 1-3 releases" and state = opened
Open frontend issues from Next 1-3 releases
display: table
fields: epic, title, assignee, weight, labels("frontend-weight::*", "workflow::*")
query:
  group = "gitlab-org" and label = "group::code review"
  and label in ("frontend") and label != "type::ignore"
  and milestone = "Next 1-3 releases" and state = opened

Quick wins

Weight 1 backend issues
display: table
fields: assignee, weight, title, milestone, updatedAt
query: group = "gitlab-org" and label = "group::code review" and label = "backend" and weight = 1 and state = opened
Weight 1 cli issues
display: table
fields: assignee, weight, title, milestone, updatedAt
query: project = "gitlab-org/cli" and label = "group::code review" and weight = 1 and state = opened
Weight 1 frontend issues
display: table
fields: assignee, weight, title, milestone, updatedAt
query: group = "gitlab-org" and label = "group::code review" and label = "frontend" and weight = 1 and state = opened
quick win issues
display: table
fields: assignee, weight, title, milestone, updatedAt
query: group = "gitlab-org" and label = "group::code review" and label = "quick win" and state = opened

Stable counterparts

Staff+ engineers

All engineers are welcome to contribute to the planning process! Staff+ engineers are expected to contribute, see references below, and are therefore tagged here explicitly to ensure visiblity as soon as the issue is created.

Handbook references:

  • Staff+ archetype - Tech Lead
    • "A Staff Engineer partners with the Engineering Manager and the Product Manager for milestone planning"
  • Staff+ archetype - Right hand
    • "Staff+ Engineers are supposed to broaden the perspectives of their managers. Decision-makers often need the additional context and perspective to make well-informed decisions about investments in the product architecture, understanding expected ROI"
  • Development Staff career framework
    • "Works with the Engineering Manager to assign work to the team"

Missing labels / weights

%18.2 issues without a backend / frontend / cli label (list should be empty except for documentation only issues):

display: table
fields: assignee, labels("documentation"), title
query:
  group = "gitlab-org" and label in ("group::code review") and milestone = "18.2"
  and label != "type::ignore" and state = opened
  and label != "frontend" and label != "backend" and label != "cli"

%18.2 issues without a weight (list should be empty):

display: table
fields: assignee, labels("backend", "frontend"), weight, labels("backend-weight::*", "frontend-weight::*"), title
query:
  group = "gitlab-org" and label in ("group::code review") and milestone = "18.2"
  and label != "type::ignore" and state = opened
  and weight = None

*-Abilities

%18.2 Deliverable issues should be labelled with an Abilities::* label if they contribute to one of the *-abilities.

%18.2 deliverables
title: Deliverable issues
display: table
fields: epic, title, labels("backend", "cli", "frontend"), labels("type::*", "maintenance::*", "feature::*", "bug::*"), labels("Abilities::*")
query:
  group = "gitlab-org" and label = "group::code review"
  and label in ("backend", "cli", "frontend") and label != "type::ignore"
  and label = "Deliverable"
  and milestone = "18.2"

(improve this template?)

Edited by François Rosé