Skip to content

Code Review 18.0 Planning : April

Release planning for the Code Review Group

Overview - 18.0 Release Board

Backend

Planning distribution

Priorities

  1. security &17042
    1. https://gitlab.com/gitlab-org/gitlab/-/issues/519340
    2. https://gitlab.com/gitlab-org/gitlab/-/issues/525338
  2. infradev
    1. https://gitlab.com/groups/gitlab-org/-/epics/16385 - implement
    2. &13435 - step 2
  3. corrective action &13512
    1. https://gitlab.com/groups/gitlab-org/-/epics/17117 - step 1, also infradev
    2. TODO: Review other actions to stack rank
  4. AI
    1. Duo Code Review GA - &13979 (closed)
      1. More context: &17361 (closed)
      2. Auto reviews: &17324 (closed)
      3. Evaluation: &17325 (closed)
    2. https://gitlab.com/groups/gitlab-org/-/epics/17140 - Need a tiny MR + verification for https://gitlab.com/gitlab-org/fulfillment/meta/-/work_items/2228. Maybe also support testing for https://gitlab.com/gitlab-org/fulfillment/meta/-/issues/2210?
    3. GA other features - &10347 or &10769 - preference towards Code Review Summary. Pause to focus on Duo Code Review GA.
  5. Cells 1.0 - &12795
    1. @kerrizor will continue on merge_request_diff_files.
    2. @kinsingh will start work on merge_request_diff_commit_users: gitlab#517131 (closed)
    3. @marc_shaw will re-start the notes migration: gitlab#444222
  6. Feature flag cleanup - gitlab#502721 (closed) - document process change to keep this in check
  7. Stacked Diffs for the CLI - &12025 - on pause
  8. Instrumentation for the CLI - &17157
  9. Rebase & merge in 1 click - &16803 - gitlab#519381 (closed) - in discussion with Gitaly on approach
  10. Rapid Diffs - &13764 (closed) - pause in favor of infradev? 3 issues left, maybe whitespace issue? Better keep it in Source Code.

Frontend

Planning distribution

Priorities

  1. Composer:
    1. Interaction/UX follow ups
    2. Expand composer to domains beyond MRs
  2. Action focused MR Homepage:
    1. Telemetry
    2. Address feedback?
  3. Reports tab Handover
  4. Intelligent merge request reviewer selection (&14808)
    1. Backtesting - spike
  5. Rapid Diffs

Issues scheduled for 18.0

Unassigned issues backend / frontend (should be empty by the end of planning)
display: table
fields: epic, title, assignee, weight, labels("type::*", "backend", "frontend")
query:
  group = "gitlab-org" and label = "group::code review"
  and label in ("backend", "cli", "frontend") and label != "type::ignore"
  and milestone = "18.0" and opened = true
  and assignee = none
Scheduled issues (sort by epic) backend
display: table
fields: epic, title, assignee, weight, labels("type::*", "Deliverable", "Stretch")
query:
  group = "gitlab-org" and label = "group::code review"
  and label in ("backend", "cli") and label != "type::ignore"
  and milestone = "18.0" and opened = true
Scheduled issues (sort by epic) frontend
display: table
fields: epic, title, assignee, weight, labels("type::*")
query:
  group = "gitlab-org" and label = "group::code review"
  and label in ("frontend") and label != "type::ignore"
  and milestone = "18.0" and opened = true

Slippage from 17.11

Open backend issues from 17.11
display: table
fields: health, assignee, weight, labels("backend-weight::*", "workflow::*"), labels( "Deliverable", "Stretch"), title
query:
  group = "gitlab-org" and opened = true and milestone = "17.11"
  and assignee in ("garyh", "kinsingh", "marc_shaw", "patrickbajao", "dskim_gitlab") 
Open frontend issues from 17.11
display: table
fields: health, assignee, weight, labels("frontend-weight::*", "workflow::*"), labels( "Deliverable", "Stretch"), title
query:
  group = "gitlab-org" and opened = true and milestone = "17.11"
  and assignee in ("iamphill", "slashmanov", "thomasrandolph") 

Candidate issues to consider

High priority

Saturation issues: GitLab.com Resource Saturation
display: table
fields: labels("severity*"), labels("priority*"), title, epic, assignee, milestone
query:
  type in (Issue, Epic)
  and group = "gitlab-org" and label = "group::code review"
  and label = "GitLab.com Resource Saturation"
  and opened = true

Next 1-3 releases

Open backend issues from Next 1-3 releases
display: table
fields: epic, title, assignee, weight, labels("backend-weight::*", "workflow::*")
query:
  group = "gitlab-org" and label = "group::code review"
  and label in ("backend") and label != "type::ignore"
  and milestone = "Next 1-3 releases" and opened = true
Open frontend issues from Next 1-3 releases
display: table
fields: epic, title, assignee, weight, labels("backend-weight::*", "workflow::*")
query:
  group = "gitlab-org" and label = "group::code review"
  and label in ("frontend") and label != "type::ignore"
  and milestone = "Next 1-3 releases" and opened = true

Quick wins

Weight 1 backend issues
display: table
fields: assignee, weight, title, milestone, updatedAt
query: group = "gitlab-org" and label = "group::code review" and label = "backend" and weight = 1 and opened = true
Weight 1 cli issues
display: table
fields: assignee, weight, title, milestone, updatedAt
query: project = "gitlab-org/cli" and label = "group::code review" and weight = 1 and opened = true
Weight 1 frontend issues
display: table
fields: assignee, weight, title, milestone, updatedAt
query: group = "gitlab-org" and label = "group::code review" and label = "frontend" and weight = 1 and opened = true
quick win issues
display: table
fields: assignee, weight, title, milestone, updatedAt
query: group = "gitlab-org" and label = "group::code review" and label = "quick win"  and opened = true

Stable counterparts

Staff+ engineers

All engineers are welcome to contribute to the planning process! Staff+ engineers are expected to contribute, see references below, and are therefore tagged here explicitly to ensure visiblity as soon as the issue is created.

Handbook references:

  • Staff+ archetype - Tech Lead
    • "A Staff Engineer partners with the Engineering Manager and the Product Manager for milestone planning"
  • Staff+ archetype - Right hand
    • "Staff+ Engineers are supposed to broaden the perspectives of their managers. Decision-makers often need the additional context and perspective to make well-informed decisions about investments in the product architecture, understanding expected ROI"
  • Development Staff career framework
    • "Works with the Engineering Manager to assign work to the team"

Missing labels / weights

%18.0 issues without a backend / frontend / cli label (list should be empty):

display: table
fields: assignee, weight, title
query:
  group = "gitlab-org" and label in ("group::code review") and milestone = "18.0"
  and label != "type::ignore" and opened = true
  and label != "frontend" and label != "backend" and label != "cli"

%18.0 issues without a weight (list should be empty):

display: table
fields: assignee, labels("backend", "frontend"), weight, labels("backend-weight::*", "frontend-weight::*"), title
query:
  group = "gitlab-org" and label in ("group::code review") and milestone = "18.0"
  and label != "type::ignore" and opened = true
  and weight = None

(improve this template?)

Edited by André Luís