Skip to content

Online GC: Remove unnecessary on conflict clause

João Pereira requested to merge jdrpereira-master-patch-50767 into master

The GC spec describes handling insert conflicts on gc_manifest_review_queue based on the (repository_id, manifest_id) pair, in response to inserts on manifests. However, no conflicts will ever occur because manifests.id is an auto-incremented ID. Therefore, we can remove the ON CONFLICT clause as it's technically impossible to happen.

Edited by João Pereira

Merge request reports