Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C container-registry
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 194
    • Issues 194
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • container-registry
  • Merge requests
  • !299

Add support for Redis Sentinel

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged João Pereira requested to merge redigo-sentinel into master Jul 30, 2020
  • Overview 6
  • Commits 2
  • Pipelines 28
  • Changes 10

Related to #163 (closed).

The registry currently uses gomodule/redigo as the Redis client library. Contrary to go-redis/redis, this client has no built-in support for Sentinel. Alternatively, gomodule/redigo can be extended with FZambia/sentinel for Sentinel support. This is the method recommended by redigo.

Although I would prefer to switch over to go-redis/redis as it's more active and feature-rich, it does not support some of the configuration settings we currently expose (namely redis.pool.maxidle and redis.pool.maxactive), which means we would have to introduce a breaking change. To avoid this, for now we're moving forward with the least impacting change, which is using FZambia/sentinel with gomodule/redigo.

Edited Jul 31, 2020 by João Pereira
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: redigo-sentinel