Deprecate Redis pool settings to allow switching to another client
In !299 (merged) we added support for Redis Sentinel. The registry currently uses gomodule/redigo as the Redis client library. Contrary to go-redis/redis, this client has no built-in support for Sentinel.
Although we would prefer to switch over to go-redis/redis
as it's more active and feature-rich, it does not support some of the configuration settings that we currently expose, namely redis.pool.maxidle
and redis.pool.maxactive
. To avoid a breaking change in the settings, we had to move forward with the least impacting change, which was using another dependency, FZambia/sentinel, to extend gomodule/redigo
with Redis Sentinel support.
Action Items
- Deprecate the
redis.pool.maxidle
andredis.pool.maxactive
settings; - Replace
gomodule/redigo
andFZambia/sentinel
withgo-redis/redis
; - Add support for the
PoolSize
,MinIdleConns
andMaxConnAge
settings fromgo-redis/redis
.
Edited by João Pereira