Skip to content

Make kas compatible with GCP Memorystore

Mikhail Mazurskiy requested to merge ash2k/fix-redis into master

Fixes problem found in gitlab-com/gl-infra/k8s-workloads/gitlab-com!2771 (comment 1415946961).

Before:

=== CONT  TestExpiringHash_GC
    expiring_hash_test.go:248: 
        	Error Trace:	/Users/mike/src/gitlab-agent/internal/tool/redistool/expiring_hash_test.go:248
        	            				/Users/mike/src/gitlab-agent/internal/tool/redistool/expiring_hash_test.go:213
        	            				/Users/mike/src/gitlab-agent/internal/tool/redistool/expiring_hash_test.go:65
        	Error:      	Received unexpected error:
        	            	unknown command `CLIENT`, with args beginning with: `TRACKING`, `ON`, `OPTIN`, : ClientOption.DisableCache must be true for redis not supporting client-side caching or not supporting RESP3
        	Test:       	TestExpiringHash_GC

After - all tests pass.

Provisioned a GCP Memorystore Redis and a VM to use as a gateway for ssh port forwarding, made a tunnel from my laptop with ssh -i ~/.ssh/google_compute_engine -L 1234:10.36.92.67:6379 x.x.x.x, ran tests with REDIS_URL=redis://127.0.0.1:1234 set.

Edited by Mikhail Mazurskiy

Merge request reports