Add inline chart values
Adds inline chart values, as discussed in gitlab-org/gitlab#372024 (closed)
-
Add tests?
Manual testing
I set up an agent with the following configuration:
# .gitlab/agents/test/config.yaml
gitops:
charts:
- release_name: test
source:
project:
id: agent-playground/test # the agent config project
path: chart
values:
- inline:
body: the world is gonna
And a minimal chart with the following default values:
# chart/values.yaml
hello: world
body: once told me
and the following config map template:
# chart/templates/configmap.yaml
apiVersion: v1
kind: ConfigMap
metadata:
name: {{ .Values.hello | quote }}
data:
some: {{ .Values.body | quote }}
Then, in my cluster, the rendered configmap was:
apiVersion: v1
data:
some: the world is gonna
kind: ConfigMap
metadata:
annotations:
meta.helm.sh/release-name: test
meta.helm.sh/release-namespace: default
creationTimestamp: "2022-10-28T15:22:41Z"
labels:
app.kubernetes.io/managed-by: Helm
name: world
namespace: default
resourceVersion: "1485"
uid: 8af001df-555e-453b-871c-a72fb47eab20
Merge request reports
Activity
changed milestone to %15.6
assigned to @hfyngvason
added typefeature label
- Resolved by Hordur Freyr Yngvason
@Alexand can you please take the first review? Thanks!
requested review from @Alexand
- Resolved by Hordur Freyr Yngvason
- Resolved by Hordur Freyr Yngvason
I've built an image and deployed it with the example shown here. I'm getting agentk logs:
│ {"level":"warn","time":"2022-10-31T15:58:43.812Z","msg":"GetConfiguration.Recv failed","error":"rpc error: code = FailedPrecondition desc = Config: failed to parse agent configuration: protojson.Unmarshal: prot │ │ o: (line 1:126): unknown field \"values\""}
Agentk version when describing the pod looks ok:
Image: registry.gitlab.com/gitlab-org/cluster-integration/gitlab-agent/agentk:56caa6d-amd64-race
Are we missing something?
The only thing I've noticed is that I haven't added a
Chart.yml
. Were you able to deploy this without one, or just didn't mention it in the description?I'll also run the code locally instead of building an image to see what's the difference.
Edited by João Alexandre Cunha
Thanks @Alexand! I've responded to all of your questions. Let me know if there's anything else
Thanks, @hfyngvason. This LGTM!
What is the guideline here? Should I forward the MR review to Mikhail after my first approval and vice versa?
removed review request for @Alexand
requested review from @ash2k
- Resolved by Hordur Freyr Yngvason
- Resolved by Mikhail Mazurskiy
- Resolved by Mikhail Mazurskiy
- Resolved by Hordur Freyr Yngvason
- Resolved by Hordur Freyr Yngvason
mentioned in issue Alexand/growth-and-development#1 (closed)
added 2 commits
- Resolved by Hordur Freyr Yngvason
- Resolved by Hordur Freyr Yngvason
- Resolved by Hordur Freyr Yngvason
- Resolved by Mikhail Mazurskiy
- Resolved by Mikhail Mazurskiy
enabled automatic add to merge train when the pipeline for a82a9571 succeeds
mentioned in commit 18b22d8c
mentioned in issue gitlab-org/gitlab#357947 (closed)
added workflowproduction label