Loading
Backport to 19-3-stable: Assert the capped retry interval instead of the observed gap
Backport of 40f59b95 ("Assert the capped retry interval instead of the observed gap") from master to 19-3-stable, cherry-picked with -x. It applied cleanly.
Why
TestActivityRetry_MaxIntervalCap asserted the wall-clock gap between retry attempts. That gap also includes timer scan, DB round trips and dispatch, so the test is racy. The 19-3-stable pipeline has a flaky failing job (https://gitlab.com/gitlab-org/security/cluster-integration/gitlab-agent/-/jobs/17909244562), and the release process needs a green pipeline.
The commit drives scheduleActivityRetry directly and asserts on the interval Postgres computed. It no longer depends on wall time.
Review Checklist
- Be sure to consider the scalability and availability impact of these changes by evaluating the impact of them at scale.