Skip to content

Add redis readiness probe for KAS

Hordur Freyr Yngvason requested to merge add-redis-readiness-probe into master

So that we get quicker feedback when redis is misconfigured on the gitlab chart. See https://gitlab.slack.com/archives/C015U1TKV4M/p1615224468065700?thread_ts=1615160114.062800&cid=C015U1TKV4M (internal link), where redis got enabled but the problem only got noticed when an agent got deployed.

Manual QA

KAS probes

Readiness probe:

  • When Redis is available: No error when loading, renders blank page
  • When Redis is off (gdk stop redis): Renders redis: dial unix /Users/hfyngvason/src/gdk-ee/redis/redis.socket: connect: no such file or directory

Liveness probe:

  • Always renders blank page, as expected

Agentk probes

Probes always render blank pages, as expected, but I had to change

- listenAddress         = "127.0.0.1:8080"
+ listenAddress         = ":8080"

in the agent observability module to reach them from my computer. I was just running this with my local docker and it's possible a cluster behaves differently. We don't consume the probes yet anyway, so I'll address this in !318 (merged) if required.

Edited by Hordur Freyr Yngvason

Merge request reports