Skip to content

Change VERSION file to include version only without leading v

Timo Furrer requested to merge version-without-v into master
  • Change VERSION file to include version only without leading v

The actual version doesn't lead with v - that's just the tags. This aligns the KAS version with other components, like Gitaly.

However, to not introduce a new versioning schema, the build tools of gitlab-agent when prepend the v again - it's just the VERSION file that changes to not have the leading v.

Testing

Run make version in git-tree:

VERSION: 'v16.11.0-rc42-49-gb4e76699'
BUILD_REF: 'b4e76699'
BUILD_TIME: '20240422.102909'

Run make version in non-git-tree (archive: https://gitlab.com/gitlab-org/cluster-integration/gitlab-agent/-/archive/version-without-v/gitlab-agent-version-without-v.tar.gz):

$ make version
VERSION: 'v17.0.0-rc1'
BUILD_REF: 'v17.0.0-rc1'
BUILD_TIME: '20240422.102721'

Remove VERSION file and run again:

$ rm -f VERSION
$ make version
VERSION: 'unknown'
BUILD_REF: 'unknown'
BUILD_TIME: '20240422.102727'
Edited by Timo Furrer

Merge request reports