Skip to content

Only reconcile GitRepository and Receiver when spec changes

Timo Furrer requested to merge no-agent-annotation-on-flux-res into master
  • Do not write an agent id annotation on resources for Flux

Currently the agent has no way to properly "own" a Flux-related resource like the Receiver and the associated Receiver secret. This leads to a problem where multiple installed agents in the same cluster will "fight" for ownership of the annotation and overwrite it with their desired value in an infinite loop. This causes all kinds of problems, as described in #537 (closed)

This change set avoids writing the agent id at all as it's currently unused. Well, we use it to delete deprecated secret resources which is fine.

We should definitely think about how an agent can identify the resources it is responsible for.

  • Only reconcile GitRepository and Receiver when spec changes

This change set avoids a GitRepository and Receiver object reconciliation on an informed updated event when their spec hasn't changed. This avoids unnecessary subsequent calls to the kube-api and in general avoids unnecessary processing of those objects.

Refs #537 (closed)

Edited by Timo Furrer

Merge request reports