Skip to content

Draft: Fix notification events backwards compatibility

Timo Furrer requested to merge fix-notification-event-compat into master
  • Fix notification events backwards compatibility

A backwards incompatibility was accidentially introduced with !1004 (merged).

That is because the GitPushEventRequest message schema and field numbers changed to something that is incompatible.

The question is if we actually need to guarantee backwards compatibility between KAS and GitLab or if we always require them to be on the same version. I've started a discussion in https://gitlab.slack.com/archives/C04SS157XSQ/p1688543096724149 (internal).

If we don't need to guarantee backwards compatibility between KAS and GitLab, then we can drop this change set and just release and upgrade a new KAS version for 16.2 asap (as a RC) to fix compatibility in gstg and gprd. Both gstg and gprod have the feature flag to access this part of the code disabled, so there isn't an immediate risk to fix that.

Merge request reports