Skip to content
Snippets Groups Projects

fix: add default ROLLOUT_RESOURCE_TYPE=deployment

Merged Hordur Freyr Yngvason requested to merge add-default-rollout-resource-type into master
All threads resolved!

Needing to specify ROLLOUT_RESOURCE_TYPE is an obscure implementation detail that most user should not need to care about. We don't even have built-in support for other types, so we should not force users to set it.

This is especially relevant to users who include Jobs/Deploy.gitlab-ci.yml instead of Auto-DevOps.gitlab-ci.yml.

Edited by Hordur Freyr Yngvason

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • João Alexandre Cunha approved this merge request

    approved this merge request

  • LGTM. Thanks!

    @shinya.maeda, could you maintainer review it?

  • requested review from @shinya.maeda

  • Shinya Maeda approved this merge request

    approved this merge request

  • Shinya Maeda resolved all threads

    resolved all threads

  • Shinya Maeda started a merge train

    started a merge train

  • Shinya Maeda mentioned in commit e198815b

    mentioned in commit e198815b

  • merged

  • Please register or sign in to reply
    Loading