feat: affinity support
Adds support for affinity along with required Go test
Resolves #64 (closed)
Merge request reports
Activity
👋 @mesouugThank you for your contributions to GitLab. We believe that everyone can contribute and contributions like yours are what make GitLab great!
Our Merge Request coaches will ensure your contribution is reviewed in a timely manner.
To bring your merge request to the attention of the relevant team within GitLab, you can ask our bot to label it with a group label. For example, if your merge request changes a project management feature, it can be labelled by commenting
@gitlab-bot label ~"group::project management". To find the most relevant group for your change, you can look up the group based on the most relevant product category in the product categories table. Once you have found the group name, type@gitlab-bot label ~group::, then start to type the group name and select the applicable group label, then submit the comment and the bot will apply the label for you.If after a few days, there's no message from a GitLab team member, feel free to ping
@gitlab-org/coachesor ask for help by commenting@gitlab-bot help.These resources may help you to move your Merge Request to the next steps:
This message was generated automatically. You're welcome to improve it.
added Community contribution label
mentioned in issue gitlab-org/quality/triage-reports#2090 (closed)
added Category:Auto DevOps backend labels
assigned to @hfyngvason
requested review from @hfyngvason
Thanks @mesouug
⭐ This looks great! Really appreciate the tests
👍 Just one thing: Could you please also add it to
worker-deployment.yaml, the same way astolerationsgot added? Let me know what you think.Edited by Hordur Freyr Yngvasonassigned to @mesouug and unassigned @hfyngvason
added 1 commit
- 05e67d5b - feat: Added affinity config to worker-deployment
- Resolved by Hordur Freyr Yngvason
@hfyngvason Hi there. I've added requested section. Please verify.
- Last reply by Hordur Freyr Yngvason
added 1 commit
- e6ceeb96 - feat: added tests for affinity in worker-deployment
@hfyngvason Added testcase for affinity in worker-deployment. Please check. Thanks in advance.
-
Apologies for the back-and-forth @mesouug
🙇 but there's a failing test that we need to address. Could you please bump theversioninassets/auto-deploy-app/Chart.yamlto2.7.0? Thanks again! @hfyngvason Totally not a problem. I don't know full workflow and really appreciate your time and effort to help me push this feature. I've bumped version - please check.
-
Thanks again @mesouug! This LGTM
🚀 mentioned in commit 3aeb17e0
