Skip to content

fix: toggle tls-acme annotation via ingress.tls.enabled

Aaron Walker requested to merge (removed):toggle-tls-acme-annotation into master

Currently, if you disable TLS via ingress.tls.enabled, it only omits ingress.tls parameters on the ingress resource. However, kubernetes.io/tls-acme: "true" is set as a default annotation so it remains even if using TLS is not desired.

This MR moves the setting of the tls-acme annotation under the ingress.tls.enabled conditional.

This could have an unwanted side effect for a use case where the client wants to disable the TLS parameter, but not the tls-acme annotation.

Merge request reports