Skip to content

Fix: `scale` creates legacy PostgreSQL regardless of the current channel

Shinya Maeda requested to merge pass-old_postgres_enabled-to-scale into master

This MR fixes the problem recently discovered by @hfyngvason.

auto-deploy scale is the API to scale up/down the deployment. This should affect only the replica count of the deployments and should not affect the other properties therefore --reuse-values option is specified to helm upgrade.

However, this --reuse-values option doesn't work with sub-chart condition, therefore, always true is being passed so far. This creates legacy PostgreSQL instance into the deployment even if it's not necessary.

Related gitlab-org/gitlab#209045 (closed)

Edited by Shinya Maeda

Merge request reports