Skip to content

Adds template hostname to additional hosts

João Alexandre Cunha requested to merge revert-573b6083 into master

What it does

This is intended to fix the problem that wildcards hosts are currently failing to be deployed unless the user explicitly wrap them in quotes.

I first attempt to fix it was done !97 (merged), but it had to be reverted since it broke other parts of the code.

The previous MR didn't work because we added | quotes to our template "hostname" .Values. service.url. But the hostname template already adds quotes to the url, so we were adding quotes over quotes, which would break the deploy.

Therefore the solution is simply to add template "hostname" to our additional hosts, which were not making use of it.

Manual QA

Additional host got deployed successfully:

https://gitlab.com/Alexand/min-ruby-app/-/jobs/674267755#L500

Edited by João Alexandre Cunha

Merge request reports