Skip to content

add worker liveness/readinessProbe

Cong Nguyen requested to merge ntcong/auto-deploy-image:master into master

This MR adds a separate livenessProbe and readinessProbe for each worker, and it also adds support for exec probe. The reason is that there's a good chance your worker doesn't have a web interface (like with django/celery), so it has a different probe check than your website. Currently, you can't set httpGet probe for your website and a different one for your worker.

Previous discussion at gitlab-org/charts/auto-deploy-app!64 (closed)

  • Is this a breaking change?
    It won't break existing installation but it will remove probe check until you manually add one for your workers.
  • Does it have tests?
    Currently, there isn't any test for livenessProbe and readinessProbe either, so it's more work to add boilerplate to check for those parameters and I don't know if I should add one.

Merge request reports