Skip to content

Dry template utils and use tmpl engine for rails and workhorse configs

Lucas Li requested to merge config-secret-templates into main

What does this MR do?

This MR is based on !46 (merged), which includes some fixes for gitlab.yaml config. Do not merge before !46 (merged).

It includes the following changes:

  • The rails and workhorse configurations are rendered using the template engine. !47 (ada3a514)
  • Unit tests using fake go-client are added to test the rendering task. !47 (9b128eda). We may wait for !45 (diffs) to have everything in test_uils
  • MakeContext in the test utils now accepts options.
  • Unused functions and vars are removed as part of #42 (closed)

Author's Checklist

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Ensure a release milestone is set.
  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • MR has a green pipeline on GitLab.com.
  • When ready for review, MR is labeled workflowready for review per the MR workflow.

Expected

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation is created or updated.
  • Tests are added.

Related issues

Closes #42 (closed)

Edited by Lucas Li

Merge request reports