Skip to content

Ensure "Running" Phase only set if "Running" Condition is true

Mitchell Nielsen requested to merge 897-status-phase-fix into master

Summary

It's possible to set the Condition "Running" to "false" (example). Because of this, when test.sh checks if "Phase" == "Running", it concludes that the entire application is running - even if "Condition == Running" is set to False, not True.

This updates the check to ensure that both:

  • The condition type == the "running" condition
  • The "running" condition is set to "true"

If both of these criteria are met, then it will set the Status Phase to Running.

Changelog: fixed

Closes #897 (closed)

Testing

In the full pipeline run, all of the review_* jobs passed on the first try. I watched to confirm that CI didn't test the endpoint until Webservice and Sidekiq were fully running, as designed.

Edited by Mitchell Nielsen

Merge request reports