Remove redundant calls to GetTemplate

Mitchell Nielsenrequested to merge
434-helm-return-error into master

Summary

Rather than calling GetTemplate for every function, pass in the template as an argument.

This enables us to:

  • Remove redundant calls to GetTemplate (DRY)
  • Return an error instead of nil when GetTemplate fails (avoid vague reconcile crashes)
  • Check for the template error in one place
  • Focus on returning objects in query methods rather than getting the template

Closes #586 (closed)

Closes #434 (closed)

Edited by Mitchell Nielsen

Merge request reports