[CI] Ensure cleanup can run when Review stage fails

Mitchell Nielsenrequested to merge
303-ci-cleanup-workaround into master

Summary

Adds 'needs: []' to the stop_review_template job so that if the review stage fails, cleanup jobs can still be triggered.

This should be considered a temporary workaround until an official fix is found. See:

Related to #303 (closed)

Testing

In https://gitlab.com/gitlab-org/cloud-native/gitlab-operator/-/pipelines/373975193, the Review stage failed. However, the cleanup jobs could still be triggered (i.e. they didn't show This job has been skipped).

image

Edited by Mitchell Nielsen

Merge request reports