Skip to content

Draft: Handle error when charts dir is not found

Gerard Hickey requested to merge handle_no_chartsdir_found into master

Summary

In AvailableChartVersions, the error from filepath.Walk is ignored. This means that if the path doesn't exist, the failure won't be properly surfaced and can lead to confusion. This can happen when testing locally and forgetting to run scripts/retrieve_gitlab_charts.sh and/or forgetting to set HELM_CHARTS to the directory where the charts are saved.

Acceptance criteria

  • Error from filepath.Walk is caught and passed back in AvailableChartVersions calls

Nice-to-have

  • A Make target or script exists to ensure scripts are retrieved and HELM_CHARTS is set before running tests locally

Closes #311 (closed)

Merge request reports