Update to Ginkgo 2.0 when available
Summary
From https://gitlab.com/gitlab-org/cloud-native/gitlab-operator/-/jobs/1765374373#L49:
Ginkgo 2.0 is under active development and will introduce (a small number of) breaking changes.
To learn more, view the migration guide at https://github.com/onsi/ginkgo/blob/v2/docs/MIGRATING_TO_V2.md
To comment, chime in at https://github.com/onsi/ginkgo/issues/711
You are passing a Done channel to a test node to test asynchronous behavior. This is deprecated in Ginkgo V2. Your test will run synchronously and the timeout will be ignored.
Learn more at: https://github.com/onsi/ginkgo/blob/v2/docs/MIGRATING_TO_V2.md#removed-async-testing
/builds/gitlab-org/cloud-native/gitlab-operator/controllers/suite_test.go:48
You are using a custom reporter. Support for custom reporters will likely be removed in V2. Most users were using them to generate junit or teamcity reports and this functionality will be merged into the core reporter. In addition, Ginkgo 2.0 will support emitting a JSON-formatted report that users can then manipulate to generate custom reports.
If this change will be impactful to you please leave a comment on https://github.com/onsi/ginkgo/issues/711
Learn more at: https://github.com/onsi/ginkgo/blob/v2/docs/MIGRATING_TO_V2.md#removed-custom-reporters
To silence deprecations that can be silenced set the following environment variable:
ACK_GINKGO_DEPRECATIONS=1.16.4
Acceptance criteria
-
Ginkgo is updated to 2.0 !574 (merged) -
Breaking changes are addressed !574 (merged) -
(we don't seem to have ever implemented this anyway)ACK_GINKGO_DEPRECATIONS=1.16.4is removed from.test_job.variablesin CI -
Ginkgo v2 is included in the build image gitlab-org/gitlab-build-images!634 (merged) -
Ginkgo v1 is removed from the build image gitlab-org/gitlab-build-images!640 (merged)
Edited by Clemens Beck