Require previousKeyId and previousKey to be set together
What does this MR do?
-
Require
previousKeyIdandpreviousKeyto be set together. -
previousKeyIdwithoutpreviousKeyalready failed to render, but the reverse silently dropped the previous key from the seal config, so an operator who set the path and forgot the id ended up with a pod that could not unseal. -
Blanking the
previousKeydefault is what makes the check possible: a non-empty path with an empty id was the shipped default, so a symmetric check would fail to render the chart on its own values. It also lines this chart up with the GitLab chart, which defaults both to empty and documents them as a pair to set and remove together. -
Raised in review of gitlab-org/charts/gitlab!5186
-
Relates gitlab-org/gitlab#603143
Author's Checklist
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
- Ensure a release milestone is set.
- MR title and description are up to date, accurate, and descriptive.
- MR targeting the appropriate branch.
- MR has a green pipeline on GitLab.com.
- When ready for review, MR is labeled workflowready for review per the MR workflow.
Expected
- Test plan indicating conditions for success has been posted and passes.
- Documentation is created or updated.
- Tests are added.