Fix Ingress default handling

Clemens Beckrequested to merge
cb-fix-ingress-handling into main

What does this MR do?

Fix Ingress default handling

This changes the default value and the local gitlab.ingress.enabled implementation to result in:

  • Ingress is enabled by default in both standalone usage and when used as subchart.
  • In standalone mode: Ingress can be disabled by setting ingress.enabled=false.
  • In subchat mode: Ingress can be controlled via global.ingress.enabled and local overrides (openbao.ingress.enabled) take presedence.

Discovered in gitlab-org/charts/gitlab!4728 (comment 3013619973)

Author's Checklist

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Ensure a release milestone is set.
  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • MR has a green pipeline on GitLab.com.
  • When ready for review, MR is labeled workflowready for review per the MR workflow.

Expected

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation is created or updated.
  • Tests are added.

Related issues

Edited by Clemens Beck

Merge request reports