Fix annotation service misconfiguration
What does this MR do and why?
This MR is the result of the investigative work in gitlab-org/gitlab#430796 (comment 1643216508)
We've discovered that via service.annotations
the Zoekt domain name points to both: stateful set and external nginx deployment.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Checkout
main
- Update your values file to include
service: annotations: external-dns.alpha.kubernetes.io/hostname: zoekt.example.com serviceBackend: annotations: some_other_annotation: alpha
helm install gitlab-zoekt .
- Verify that both services
gitlab-zoekt
andgitlab-zoekt-gateway
haveexternal-dns.alpha.kubernetes.io/hostname
$ k describe svc gitlab-zoekt-gateway | fgrep -C1 alpha Annotations: cloud.google.com/neg: {"ingress":true} external-dns.alpha.kubernetes.io/hostname: zoekt.example.com meta.helm.sh/release-name: gitlab-zoekt $ k describe svc gitlab-zoekt | fgrep -C1 alpha Annotations: cloud.google.com/neg: {"ingress":true} external-dns.alpha.kubernetes.io/hostname: zoekt.example.com meta.helm.sh/release-name: gitlab-zoekt
git checkout fix-annotation-misconfiguration
helm upgrade gitlab-zoekt .
- Verify that annotations are now correct
$ k describe svc gitlab-zoekt-gateway | fgrep -C1 alpha Annotations: cloud.google.com/neg: {"ingress":true} external-dns.alpha.kubernetes.io/hostname: zoekt.example.com meta.helm.sh/release-name: gitlab-zoekt $ k describe svc gitlab-zoekt | fgrep -C1 alpha Annotations: cloud.google.com/neg: {"ingress":true} foo: alpha meta.helm.sh/release-name: gitlab-zoekt
Edited by Dmitry Gruzd