Skip to content

chore update go gitlab

Kerri Miller requested to merge github/fork/zemzale/chore-update-go-gitlab into trunk

Created by: zemzale

Description

This PR updates go-gitlab library to the newest version so we can add more then one file to snippets.

The problem here is that there is one huge nasty change that changes a lot of slices to be pointers to slices see here

There are also some good things as, no need to use the workaround for setting the scope for environment filters when removing project variables.

There is also a change in the way how labels are treated in most places (this actually just looks like a normalization around the library since some places already used this custom type and some didn't).

There is quite a lot of pointer derefrencing now, and I have not done any real testing so there might be some problems so this probably should be tested better before merging.

Each change should be in it's own commit for easier review, but should be squashed before merge, because most of the commits fail to build and I don't like having commits with build failures.

Commit messages should have better explanation for most changes.

Related Issue

Resolves #872

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)
Edited by 🤖 GitLab Bot 🤖

Merge request reports