Skip to content

Fix(pager): Resolve background color before staring pager

Kerri Miller requested to merge github/fork/zemzale/fix-pager-issue into trunk

Created by: zemzale

Description So far we have started the pager and then got background color glamour style from enviorment.

If enviorment value is not set it defaults to auto. Which in turn uses termenv to resolve background color using some terminal escape code sequences. The problem with this is that doing this when a pager like less is running, just doesn't work and leaves less in a broken state.

To fix this we are now checking the background color manually and before we start the pager.

Related Issue

Resolves #636 (closed)

How Has This Been Tested? Fixes hangs for less on my machine.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)

Merge request reports