Skip to content

Resolver testing

Kerri Miller requested to merge github/fork/maxice8/resolver-testing into trunk

Created by: maxice8

Description

refactor(internal/glrepo/resolver.go): remove code that is always false

This code is always false because of the following code that comes a bit before.

if r.network == nil {
    resolveNetwork(r)
    if len(r.network) == 0 {
        return nil, errors.New("no GitLab Projects found from remotes")
    }
}

This code will always return err if there are no gitlab.Project in r.network even after using resolveNetwork(), and the amount of values in repoNames on how many values there are in r.network.

Thus the code we are removing is never actually reached, or rather, it is in all situations, false.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)

Merge request reports