Loading
fix(release): send asset links in the create release request
Description
This MR fixes gitlab#574029 (closed). We have been "handling" it by manually editing and saving each release after it was created. It was quite inconvenient, so before adding a hacky stage to automate it we threw an agent at it to see how it could be properly fixed.
The main change is that instead of having the links get sent separately, they get sent in the create request. If the release already exists, it goes through the existing route.
Related Issues
Resolves #8600 (closed)
Related to gitlab#574029 (closed) (it was closed without a fix)
Related to #7859 (feedback issue for the move from release-cli to glab)
How has this been tested?
- Unit tests for
ToReleaseAssetsOptions - Updated the create test with the new behavior
- End-to-end manual test (not included):
- Our company's self-managed instance
release:job with one link- release-cli container image carrying this glab
- Replaced the used image with the patched one
- Running a tag release generated the expected effect
Edited by Raul Rabadan Arroyo